Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: define the telemetry protocol in protobuf #14952

Merged
merged 4 commits into from
Feb 4, 2024
Merged

chore: define the telemetry protocol in protobuf #14952

merged 4 commits into from
Feb 4, 2024
+177 −0

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Feb 2, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

introduce telemetry-related message schema protobuf files. Do nothing to the logic.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@tabVersion
Copy link
Contributor Author

backend change: https://github.com/risingwavelabs/telemetry-backend/pull/24

@tabVersion tabVersion marked this pull request as ready for review February 2, 2024 08:49
@tabVersion
Copy link
Contributor Author

tabVersion commented Feb 2, 2024 •
edited
Loading

Let's merge this first to push forward the backend refactor, which is relying on the main branch of the repo

@tabVersion tabVersion changed the title refactor: make telemetry content in protobuf chore: define the telemetry protocol in protobuf Feb 2, 2024
fuyufjh
fuyufjh approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please say something in the PR description, so that we can know the background when reading git history.

@tabVersion tabVersion enabled auto-merge February 4, 2024 09:30
@tabVersion tabVersion added this pull request to the merge queue Feb 4, 2024
Merged via the queue into main with commit 42cc7c8 Feb 4, 2024
28 of 29 checks passed
@tabVersion tabVersion deleted the tab/telemetry-pb branch February 4, 2024 10:19
This was referenced Feb 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

Assignees
No one assigned
Labels
type/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabVersion @fuyufjh